Skip to content
GitLab
Explore
Sign in
ilias-core
ilias-archive
Compare revisions
b2de6b0ea0970ae7d10528bc058b75e6f2ed833e to c329a6afcf68e3a67d8ac2a303de5ee8f3e8f508
Commits on Source (2)
ILIAS8 Review Services/Accessibility 2
· 3466214b
Uwe Kohnle
authored
Apr 15, 2022
3466214b
Merge pull request #4370 from internetlehrer/pr_services_accessibility
· c329a6af
Alex Killing
authored
Apr 22, 2022
ILIAS8 Review Services/Accessibility 2
c329a6af
Hide whitespace changes
Inline
Side-by-side
Services/Accessibility/classes/Criteria/class.ilAccessibilityDocumentCriterionAssignment.php
View file @
c329a6af
...
@@ -16,6 +16,9 @@
...
@@ -16,6 +16,9 @@
/**
/**
* Class ilAccessibilityDocumentCriterionAssignment
* Class ilAccessibilityDocumentCriterionAssignment
*/
*/
//TODO PHP8-REVIEW: check undefined methods
//Method 'setAssignedTs' is undefined
//Method 'setModificationTs' is undefined
class
ilAccessibilityDocumentCriterionAssignment
extends
ActiveRecord
implements
ilAccessibilityEvaluableCriterion
,
ilAccessibilityEquatable
class
ilAccessibilityDocumentCriterionAssignment
extends
ActiveRecord
implements
ilAccessibilityEvaluableCriterion
,
ilAccessibilityEquatable
{
{
public
const
TABLE_NAME
=
'acc_criterion_to_doc'
;
public
const
TABLE_NAME
=
'acc_criterion_to_doc'
;
...
@@ -94,6 +97,7 @@ class ilAccessibilityDocumentCriterionAssignment extends ActiveRecord implements
...
@@ -94,6 +97,7 @@ class ilAccessibilityDocumentCriterionAssignment extends ActiveRecord implements
public
function
create
()
:
void
public
function
create
()
:
void
{
{
//TODO PHP8-REVIEW: check undefined method 'setAssignedTs'
$this
->
setAssignedTs
(
time
());
$this
->
setAssignedTs
(
time
());
parent
::
create
();
parent
::
create
();
...
@@ -101,6 +105,7 @@ class ilAccessibilityDocumentCriterionAssignment extends ActiveRecord implements
...
@@ -101,6 +105,7 @@ class ilAccessibilityDocumentCriterionAssignment extends ActiveRecord implements
public
function
update
()
public
function
update
()
{
{
//TODO PHP8-REVIEW: check undefined method 'setModificationTs'
$this
->
setModificationTs
(
time
());
$this
->
setModificationTs
(
time
());
parent
::
update
();
parent
::
update
();
...
...
Services/Accessibility/classes/Criteria/class.ilAccessibilityDocumentCriterionAssignmentConstraint.php
View file @
c329a6af
...
@@ -57,7 +57,9 @@ class ilAccessibilityDocumentCriterionAssignmentConstraint extends Constraint
...
@@ -57,7 +57,9 @@ class ilAccessibilityDocumentCriterionAssignmentConstraint extends Constraint
return
array_filter
(
return
array_filter
(
$otherValues
,
$otherValues
,
function
(
ilAccessibilityDocumentCriterionAssignment
$otherValue
)
use
(
$value
)
{
function
(
ilAccessibilityDocumentCriterionAssignment
$otherValue
)
use
(
$value
)
{
//TODO PHP8-REVIEW: check undefined method 'getId()'
$idCurrent
=
$otherValue
->
getId
();
$idCurrent
=
$otherValue
->
getId
();
//TODO PHP8-REVIEW: check undefined method 'getId()'
$idNew
=
$value
->
getId
();
$idNew
=
$value
->
getId
();
$uniqueIdEquals
=
$idCurrent
===
$idNew
;
$uniqueIdEquals
=
$idCurrent
===
$idNew
;
...
...
Services/Accessibility/classes/Document/class.ilAccessibilityDocument.php
View file @
c329a6af
...
@@ -135,6 +135,7 @@ class ilAccessibilityDocument extends ActiveRecord implements ilAccessibilitySig
...
@@ -135,6 +135,7 @@ class ilAccessibilityDocument extends ActiveRecord implements ilAccessibilitySig
public
function
create
()
:
void
public
function
create
()
:
void
{
{
//TODO PHP8-REVIEW: check undefined method 'setCreationTs'
$this
->
setCreationTs
(
time
());
$this
->
setCreationTs
(
time
());
parent
::
create
();
parent
::
create
();
...
...
Services/Accessibility/classes/Document/class.ilAccessibilityDocumentFormGUI.php
View file @
c329a6af
...
@@ -22,6 +22,14 @@ use ILIAS\FileUpload\Location;
...
@@ -22,6 +22,14 @@ use ILIAS\FileUpload\Location;
/**
/**
* Class ilAccessibilityDocumentFormGUI
* Class ilAccessibilityDocumentFormGUI
*/
*/
//TODO PHP8-REVIEW: check undefined methods
//Method 'getId' is undefined
//Method 'getTitle' is undefined
//Method 'setText' is undefined
//Method 'setTitle' is undefined
//Method 'setLastModifiedUsrId' is undefined
//Method 'setOwnerUsrId' is undefined
//Method 'setSorting' is undefined
class
ilAccessibilityDocumentFormGUI
extends
ilPropertyFormGUI
class
ilAccessibilityDocumentFormGUI
extends
ilPropertyFormGUI
{
{
protected
ilAccessibilityDocument
$document
;
protected
ilAccessibilityDocument
$document
;
...
@@ -33,6 +41,7 @@ class ilAccessibilityDocumentFormGUI extends ilPropertyFormGUI
...
@@ -33,6 +41,7 @@ class ilAccessibilityDocumentFormGUI extends ilPropertyFormGUI
protected
string
$cancelCommand
;
protected
string
$cancelCommand
;
protected
bool
$isEditable
=
false
;
protected
bool
$isEditable
=
false
;
protected
string
$translatedError
=
''
;
protected
string
$translatedError
=
''
;
//TODO PHP8-Review: Missing property's type declaration
protected
$translatedInfo
=
''
;
protected
$translatedInfo
=
''
;
protected
ilHtmlPurifierInterface
$documentPurifier
;
protected
ilHtmlPurifierInterface
$documentPurifier
;
...
...
Services/Accessibility/classes/Document/class.ilAccessibilityDocumentGUI.php
View file @
c329a6af
...
@@ -22,6 +22,10 @@ use ILIAS\UI\Renderer;
...
@@ -22,6 +22,10 @@ use ILIAS\UI\Renderer;
/**
/**
* Class ilAccessibilityDocumentGUI
* Class ilAccessibilityDocumentGUI
*/
*/
//TODO PHP8-REVIEW: check undefined methods
//Method 'getId' is undefined
//Method 'getTitle' is undefined
//Method 'setSorting' is undefined
class
ilAccessibilityDocumentGUI
implements
ilAccessibilityControllerEnabled
class
ilAccessibilityDocumentGUI
implements
ilAccessibilityControllerEnabled
{
{
protected
ilAccessibilityTableDataProviderFactory
$tableDataProviderFactory
;
protected
ilAccessibilityTableDataProviderFactory
$tableDataProviderFactory
;
...
...
Services/Accessibility/classes/Document/class.ilAccessibilityDocumentTableGUI.php
View file @
c329a6af
...
@@ -19,6 +19,12 @@ use ILIAS\UI\Renderer;
...
@@ -19,6 +19,12 @@ use ILIAS\UI\Renderer;
/**
/**
* Class ilAccessibilityDocumentTableGUI
* Class ilAccessibilityDocumentTableGUI
*/
*/
//TODO PHP8-REVIEW: check undefined methods
//Method 'getTitle' is undefined
//Method 'getCreationTs' is undefined
//Method 'getModificationTs' is undefined
//Method 'getText' is undefined
//Method 'getId' is undefined
class
ilAccessibilityDocumentTableGUI
extends
ilAccessibilityTableGUI
class
ilAccessibilityDocumentTableGUI
extends
ilAccessibilityTableGUI
{
{
protected
ILIAS
\UI\Factory
$uiFactory
;
protected
ILIAS
\UI\Factory
$uiFactory
;
...
...